Welcome to EnviroDIY, a community for do-it-yourself environmental science and monitoring. EnviroDIY is part of Home › Forums › Mayfly Data Logger › Double_logger example modification › Reply To: Double_logger example modification
@w3asa – I don’t have formal training in computer science or even in electrical engineering. I have one bachelor’s level degree – in chemistry.
@stoltzfus-12osu-edu – two things with your code – and I completely understand why you did it the way you did – because the example did. Blame the chemist.
1 – you’re creating each variable 3 times instead of creating it once and then referring it to that same one later. Each time you use that “new” keyword it creates a new variable, but you can only assign one variable of each type to a sensor so the other two weren’t getting updated. In the double logging example it worked fine to create the variables with “new” right in the variable array because there was no overlap between the two arrays. But that definitely wansn’t made clear and is confusing. Anyway, to fix that change your variable arrays so that instead of creating a new variable they use the same variable that you already created up in the sensor sections like so:
|
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 |
// ========================================================================== // Creating the Variable Array[s] and Filling with Variable Objects // ========================================================================== // The variables to record at 1 minute intervals Variable *variableList_low[] = { ds3231Temp, new ProcessorStats_FreeRam(&mcuBoard, "xxxxx"), tbi2cDepth, modemRSSI, modemSignalPct, // ds18TempVar // if you're using this, you should create above extvoltV, }; // Count up the number of pointers in the 1-minute array int variableCountLow = sizeof(variableList_low) / sizeof(variableList_low[0]); // Create the 1-minute VariableArray object VariableArray arrayLow; // The variables to record at 5 minute intervals Variable *variableList_high[] = { new ProcessorStats_Battery(&mcuBoard), ds3231Temp, tbi2cDepth, modemRSSI, modemSignalPct, // ds18TempVar // if you're using this, you should create above extvoltV, }; // Count up the number of pointers in the 5-minute array int variableCountHigh = sizeof(variableList_high) / sizeof(variableList_high[0]); // Create the 5-minute VariableArray object VariableArray arrayHigh; |
Since you only use the free RAM in one of the two arrays and battery in the other and you didn’t create either at the top, it’s fine to create them “new” in the array. If you decide you do want them in both or the look of the code bothers you, you can create the free ram and battery variables with statements like Variable *yourVarName = new ProcessorStats_FreeRam(&mcuBoard, ...) up in the processor section or elsewhere above.
2 – Modems in ModularSensors are special; they don’t get updated like regular variables tied to a sensor. The signal quality isn’t update until *after* you send out some data. With each cycle, the signal strength saved to the csv and posted is actually the data from one cycle prior. And if you never post data (you don’t) and explicitly update the modem metadata, the values don’t update. You’d want to add publishing code like this in the “high” section right after turning off the SD card.
|
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 |
// Connect to the network if (modem.modemWake()) { loggerLow.watchDogTimer.resetWatchDog(); if (modem.connectInternet()) { loggerLow.watchDogTimer.resetWatchDog(); // Publish data to remotes loggerHigh.publishDataToRemotes(); modem.updateModemMetadata(); loggerLow.watchDogTimer.resetWatchDog(); // Sync the clock at midnight // NOTE: All loggers have the same clock, pick one if (Logger::markedEpochTime != 0 && Logger::markedEpochTime % 86400 == 0) { Serial.println(F("Running a daily clock sync...")); loggerLow.setRTClock(modem.getNISTTime()); } // Disconnect from the network loggerLow.watchDogTimer.resetWatchDog(); modem.disconnectInternet(); } } // Turn the modem off loggerLow.watchDogTimer.resetWatchDog(); modem.modemSleepPowerDown(); |
